On 11/25/2013 07:24 AM, Daniel P. Berrange wrote: >> object-locking-files.txt >> + >> +# Some tests tend to write into files. Notably, the virpcitest, which detach >> +# and reset a pci device (achieved byt writing into a pci config file). >> +check-local: >> + chmod -R u+w $(srcdir)/virpcitestdata/
NACK. This will fail if $(srcdir) is on a read-only mount point (such as a CDROM). > > I seem to recall eric saying on IRC that we shouldn't do this, and that > any files the test suite writes to should be located in $(builddir) > not $(srcdir). Indeed. The correct way is to move these files to $(builddir) (which is always writable) and quit trying to ship them in the tarball - they only need to exist for the duration of the test, so the tarball only needs rules on how to generate the files into $(builddir) at the start of the test. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
