Jim Fehlig wrote: > Chunyan Liu wrote: > >> Add hostdev passthrough common library so that it could be shared by all >> drivers >> and maintain a global hostdev state. >> >> > > Hi Chunyan, > > Looks like you addressed all of Daniel's comments from v5. One bug fix > and a few additional comments below... >
I forgot to mention that this patch causes failures of qemuxml2argvtest, qemuxml2xmltest, and qemuargv2xmltest when doing 'make check'. Speaking of the unit tests, as Laine noted we should look at providing improved unit tests for this new common library. Can you expand the series with a patch testing the virhostdev interface? Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
