On Wed, Dec 11, 2013 at 11:38:03AM +0100, Cédric Bosdonnat wrote:
> ---
>  src/conf/domain_event.c         | 286 
> +++++++++++++++++++++++-----------------
>  src/conf/domain_event.h         | 271 +++++++++++++++++++++----------------
>  src/conf/object_event.c         |  47 ++++---
>  src/conf/object_event_private.h |  20 +--
>  4 files changed, 364 insertions(+), 260 deletions(-)
> 
> diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
> index da57129..45e48b6 100644
> --- a/src/conf/domain_event.c
> +++ b/src/conf/domain_event.c
> @@ -443,11 +443,12 @@ virDomainEventCallbackListAdd(virConnectPtr conn,
>  }
>  
>  
> -static void *virDomainEventNew(virClassPtr klass,
> -                               int eventID,
> -                               int id,
> -                               const char *name,
> -                               const unsigned char *uuid)
> +static void
> +*virDomainEventNew(virClassPtr klass,

The '*' should be on the same line as the void.

> +                   int eventID,
> +                   int id,
> +                   const char *name,
> +                   const unsigned char *uuid)
>  {
>      virDomainEventPtr event;



> @@ -460,11 +464,12 @@ error:
>      return NULL;
>  }
>  
> -void *virObjectEventNew(virClassPtr klass,
> -                        int eventID,
> -                        int id,
> -                        const char *name,
> -                        const unsigned char *uuid)
> +void
> +*virObjectEventNew(virClassPtr klass,

And here

> +                   int eventID,
> +                   int id,
> +                   const char *name,
> +                   const unsigned char *uuid)
>  {
>      virObjectEventPtr event;
>  

> -void *virObjectEventNew(virClassPtr klass,
> -                        int eventID,
> -                        int id,
> -                        const char *name,
> -                        const unsigned char *uuid);
> +void
> +*virObjectEventNew(virClassPtr klass,

And here

> +                   int eventID,
> +                   int id,
> +                   const char *name,
> +                   const unsigned char *uuid);


ACK will fix those bugs.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to