On 12/18/2013 06:09 AM, Eric Blake wrote: > On 12/18/2013 02:35 AM, Martin Kletzander wrote: >> When test-locking is enabled, CFLAGS have -Dbool=char, which makes > > Huh? bool should never be defined to char in CFLAGS; it should only be > replaced if gnulib thinks the compiler is too old.
I actually looked at configure.ac, and wow, we really ARE doing -Dbool=char when trying to use CIL. Yuck. I think --with-test-locking has bit-rotted for some time now, and is going to need a LOT of work before it can be considered usable. That option was added in commit 6962a2d, in 2009, which predates my time on libvirt, and I don't ever recall using it myself. I'm not familiar enough with CIL to speculate why it doesn't work with C99 bool (or maybe that was a limitation back in 2009 but has since been fixed). Dan? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
