On 01/07/2014 08:36 AM, Laine Stump wrote: >> Yes, I think I could live with such a footnote. And even if we get >> outvoted and someone else requests the permanent code clutter, we can >> add that as a separate commit which gives the further justification of >> why we are adding it. > > Okay. I *think* that the bugzilla record and this email thread should be > enough that anyone encountering the problem will find the solution after > a quick google search. I don't know that putting it in libvirt release > notes would be of any use, since the release it *should* have been noted > in is long past...
Agreed. >>> cleanup: >>> VIR_FREE(devStr); >>> + VIR_FREE(tempAlias); >> and you then free tempAlias. That leaves contAlias pointing at stale >> memory. That doesn't feel right. > > But by this time contAlias is already long ago out of scope. Ah, that's the context I was missing. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
