On 01/16/2014 01:09 AM, Bing Bu Cao wrote: >> Can you also provide a test case to validate this. You just >> need to get a suitable /proc/cpustat file and save it in the >> tests/ dir and then include linuxNodeGetCPUStats() using that >> file. > I found there is no test case for linuxNodeGetCPUStats() right now, it > is 'static' there. > I think adding a new test case to validate linuxNodeGetCPUStats() should > not only cover this patch. > > What do you think posting another patch to adding the test case?
Adding patches to enhance the testsuite is always a good idea. Go for it! -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
