On 02/24/2014 08:21 AM, Peter Krempa wrote: > In storageVolLookupByPath the provided path is "sanitized" at first. > This removes some extra slashes and stuff. When the lookup of the volume > fails the original path is used which makes it hard to trace errors in > some cases. > > Improve the error message to print the sanitized path along with the > user provided path if they are not equal. > --- > src/storage/storage_driver.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >
> + _("no storage vol with matching path '%s'"), > path); > + } else { > + virReportError(VIR_ERR_NO_STORAGE_VOL, > + _("no storage vol with matching path '%s' (%s)"), > path, cleanpath); Long line; break after the first ',' ACK with that change; makes sense to me to give a bit more information in the error message. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list