Eric Blake wrote: > On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: >> >>> At Fri, 21 Feb 2014 11:01:47 +0000, >>> Daniel P. Berrange wrote: >>> >>>> ACK, if you also add the virEventUpdateTimeout method >>>> >>> OK, but why should I add it? It's useless (for the user) and unused by >>> the wrapping code. I want to keep the JNA library definition clean -- >>> e.g. in a later patch I remove all the *UUIDString functions. >>> >> What makes you say it is useless ? The UpdateTimeout method lets you >> alter the timeout value for an existing timer, without having to go >> through Remove+Add of it. This might seem like a subtle distinction, >> but the difference is that the UpdateTimeout is guaranteed not to >> fail, where as Remove+Add may fail. >> > > In fact, in my recent 'virsh event' additions, I explicitly used code > that adds a timer with a -1 initial period (never fires),
The libxl driver also temporarily disables timers in this way. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
