On 03/06/2014 08:24 AM, Laine Stump wrote: > This file was using multiple virBuffers, inserting the contents of > buf3 into buf2, then inserting the contents of buf2 into buf1, rather > than the more conventional method of just passing around a single > virBufferPtr and streaming everything into that single buffer. This > was unnecessary, and also made it more difficult to make indentation > relative, because when you insert a string into a buffer, the > indentation of the buffer is only applied once at the beginning of the > string, *not* each time a newline is encountered in the string. > --- > src/conf/nwfilter_conf.c | 94 > ++++++++++++++-------------------------------- > src/conf/nwfilter_params.c | 6 ++- > 2 files changed, 32 insertions(+), 68 deletions(-) >
ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
