On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
Convert the nwfilter ebtablesRemoveBasicRules method to use the
virFirewall object APIs instead of creating shell scripts
using virBuffer APIs. This provides a performance improvement
through allowing direct use of firewalld dbus APIs and will
facilitate automated testing.

Signed-off-by: Daniel P. Berrange <berra...@redhat.com>



  static void
-ebtablesRemoveSubChainsFW(virFirewallPtr fw,
-                          const char *ifname)
+ebtablesRemoveTmpSubChains(virBufferPtr buf,
+                           const char *ifname)
  {
      char chains[3] = {
-        CHAINPREFIX_HOST_IN,
-        CHAINPREFIX_HOST_OUT,
+        CHAINPREFIX_HOST_IN_TEMP,
+        CHAINPREFIX_HOST_OUT_TEMP,
          0
      };

-    _ebtablesRemoveSubChainsFW(fw, ifname, chains);
+    _ebtablesRemoveSubChains(buf, ifname, chains);
  }

This is really the only odd part about this patch, a conversion in the other direction. Maybe not-yet converted code needs it at this point.

ACK


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to