On Mon, May 12, 2014 at 05:12:45PM -0600, Eric Blake wrote: > On 05/12/2014 07:22 AM, Michal Privoznik wrote: > > On 10.05.2014 01:21, Tomoki Sekiyama wrote: > >> Add binding for the new virDomainFSFreeze and virDomainFSThaw functions > >> added in libvirt 1.2.5. These require override since these take a list > >> of mountpoints path string. The methods are named 'fSFreeze' and 'fSThaw', > >> like a existing 'fSTrim' method. > > Eww. I'd rather 'fsFreeze' and 'fsThaw' - how baked in is the 'fSTrim' > naming?
The existing APIs are broken since the generator doesn't cope with the input parameters, so there's no issue changing the name. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
