On 05/30/2014 02:37 AM, Peter Krempa wrote: > Use the new backing store parser in the backing chain crawler. This > change needs one test change where information about the NBD image are > now parsed differently. > --- > src/storage/storage_driver.c | 90 > +------------------------------------------- > tests/virstoragetest.c | 14 ++++--- > 2 files changed, 9 insertions(+), 95 deletions(-)
Nice diffstat! > > +++ b/tests/virstoragetest.c > @@ -730,20 +730,22 @@ mymain(void) > /* Rewrite qcow2 to use an nbd: protocol as backend */ > virCommandFree(cmd); > cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", > - "-F", "raw", "-b", "nbd:example.org:6000", > + "-F", "raw", "-b", > "nbd:example.org:6000:exportname=blah", Nice increased test coverage. I'm glad I spent the time on the testsuite, it makes changes like this more reassuring. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
