On 06/24/14 01:30, Eric Blake wrote: > With this in place, I can (finally!) now do: > > virsh blockcommit $dom vda --shallow --verbose --pivot > > and watch qemu shorten the backing chain by one, followed by > libvirt automatically updating the dumpxml output, effectively > undoing the work of virsh snapshot-commit --no-metadata --disk-only. > Commit is SOOOO much faster than blockpull, when I'm still fairly > close in time to when the temporary qcow2 wrapper file was created > via a snapshot operation! > > Still not done: the persistent XML is not updated; which means > stopping and restarting a persistent guest will use the wrong > file and likely fail to boot. > > * src/qemu/qemu_driver.c (qemuDomainBlockCommit): Implement live > commit to regular files. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > src/qemu/qemu_driver.c | 40 +++++++++++++++++++++++++++++++++++----- > 1 file changed, 35 insertions(+), 5 deletions(-) >
ACK as previously. This will obviously need a followup to deal with networked disks too. Peter
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
