Hello,

here is a patch which adds some mpre documentation for repot_tags and
ignore_tags.  I also added some test cases.

I changed the t/filter-methods.t to use Test::More, as this gives nice
error messages if tests fail (which they did while I was trying to
figure this stuff out :-).  Only drawback is that this makes it
dependent on Test::More, but I think that is used by many other modules
as well.  If you think that's unacceptable, I'd be willing to rewrite it
without using Test::More.

Best,
  Norbert

On Tue, 2005-06-14 at 11:48 -0700, Gisle Aas wrote:
> Norbert Kiesel <[EMAIL PROTECTED]> writes:
> 
> > On Tue, 2005-06-14 at 04:44 -0700, Gisle Aas wrote:
> > > Norbert Kiesel <[EMAIL PROTECTED]> writes:
> > > 
> > > > I tried to use ->ignore_tags(()) and ->ignore_tags(qw(none)), but it
> > > > seems that after calling ->report_tags() once it alsways uses a positive
> > > > tag filter.
> > > 
> > > Calling ->report_tags() without any arguments should reset the filter.
> > 
> > Thanks, just tested it and it works beautifully.   Perhaps this
> > information could be added to the manual or FAQ?
> 
> Documenting this better would be a good idea.  I'll try to do get it
> done for the next release.  Patches welcome.
> 
> > Also, what is the semantics of combining ->ignore_tags() and
> > ->report_tags()?  My understanding is that the last call wins, i.e. it
> > replaces (instead of modifies) the internal filter.  Is this correct?
> 
> If both ignore_tags and report_tags are set then they both filter out
> events and ignore_tags effectively takes precendence.  For example:
> 
>    $p->ignore_tags("a");
>    $p->report_tags("a", "b");
> 
> Only "b" will be reported.  This should probably also be documented
> better.
> 
> Regards,
> Gisle
> 

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to