On tis, 2008-04-22 at 11:43 +0200, Ladislav Michnovič wrote: > On Mon, Apr 21, 2008 at 6:10 PM, Anders Olofsson <[EMAIL PROTECTED]> wrote: > > > > > > > Hello. > > > The latest glibc 2.8 doesn't include limits.h automatically and there > > > are some other inclusions of header files missing needed to compile > > > the licq with latest 4.x gcc without errors. Attaching the patch. Can > > > you add it into the svn, please? > > > Regards Ladislav. > > > > Hi, > > I'm a bit curious to what errors/warnings you get without this patch. > > For example, in include/licq_icqd.h you add forward declarations for > > ICQDaemon functions that are declared one page later in the same header > > file. > > And you add cassert to src/socket.cpp but there is no use of assert() in > > that file. > > > > Could you please provide the compiler errors/warnings this patch fixes. > > > Yes I can. Actually the attached patch consists of three patches > which are used in openSUSE distribution. > The cassert inclusion is outdated. It is a very old patch and the > assert.h inclusion was missing in the past but not now. I have > overlooked it. But inclusion of cassert instead of assert.h can be > used in c++ code. > This > +++ include/licq_buffer.h > +#include <cstring> > > ../include/licq_buffer.h:67: error: 'memcpy' was not declared in this scope > > Declaration is commented why it is so and the several inclusions of > +#include <limits.h> > is because this (only with glibc >= 2.8) > > fifo.cpp: In function 'long unsigned int StringToStatus(char*)': > fifo.cpp:181: error: 'INT_MAX' was not declared in this scope > fifo.cpp: In function 'int fifo_status(int, const char* const*, void*)': > fifo.cpp:357: error: 'INT_MAX' was not declared in this scope > > Regards Ladislav.
I checked some more and committed what I could find reasons for in r6168. The ones I didn't include were src/socket.cpp and include/licq_icqd.h. Thanks. /Anders
