Sergey, Sorry for the long delay, but I finally got your SSBI patch merged into SVN. There were a few things I changed: * Changed the name of SSBI to BART (Buddy Art) * Fixed a few memory leaks * Made use of boost in a few places (would like to see more actually...) * Changed the saving of pictures from using %lu as the name to %s, so it works with AIM users (not all cases though) * Added constants for the BART Types * Added support for the qt4-gui.
The oscarservice file seems to replicate a lot of code from icqd-srv.cpp, such as the the way it processes packets. It would have been nice to get that simplified down, but I commited as is. As for the memory leaks, there was a case of new being called and no delete. I changed it to using boost::scoped_array, so there is no need to remember to call delete. And when reading the buddy icon hash from the user's config file, the string never got free'd in the user's destructor. So if the user got deleted, their would be a leak. I'll be addind a few more fixes to get it working with all AIM users soon. Thanks, Jon On Tuesday 22 January 2008, Sergey Kononenko wrote: > Hello, > > This is new version of patch that add SSBI (server side buddy icon (or > user picture)) support to licq. Changes from prior versions: > 1. Fixed handling of icq direct client to client communication which > was completely broken in previous versions of patch. > 2. Fixed crash on exit when UseSSBI is off. > > With best regards, > Sergey Kononenko. -- ________________________________________________________ Jon Keating ICQ: 16325723 [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] http://www.licq.org GPG: 2290A71F http://www.thejon.org HOME: Tokyo, Japan
