-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Saturday 09 November 2002 01:18, Juan F. Codagnone wrote:
> On Friday 08 November 2002 14:58, Thomas Reitelbach wrote:
[snip]
> > the logic in the systems history in qt-gui is broken, the buttons for
> > walking forwards and backwards through the history are not associated
> > with the correct functions correctly.
[snip]
> > It's like this:
> > Save --> walks back
>
> why is this needed?
It isn't... i just wanted to say how it behaves _before_ using my patch.
> i applied your patch with a clean copy of userinfodlg.cpp and now the Prev
> button dont work at any user's history (but work at the owner history)
Thanks for your hint, in future i'll take a cup of coffee before doing such
stupid things *g*
> What do you think of my 2_enabled.diff?
hm, i didn't find it attached...
But i made a new patch, only few changes were needed to make it work again :)
Please apply my new patch on a clean/unpatched copy of userinfodlg.cpp and
tell me if it now works for you, for me at least it does :)
Bye,
Thomas
- --
Don't get to bragging.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE9zNeF+83LmoKU5MARAmD9AJ9Dj788fOfokXy4vDPNvoi+38eL1QCfRPAl
ztzNI78fBYk40JtcZUl7ByA=
=Fe1k
-----END PGP SIGNATURE-----
Index: licq/plugins/qt-gui/src/userinfodlg.cpp
===================================================================
RCS file: /cvsroot/licq/qt-gui/src/userinfodlg.cpp,v
retrieving revision 1.58
diff -u -3 -p -r1.58 userinfodlg.cpp
--- licq/plugins/qt-gui/src/userinfodlg.cpp 5 Nov 2002 06:26:02 -0000 1.58
+++ licq/plugins/qt-gui/src/userinfodlg.cpp 9 Nov 2002 09:31:14 -0000
@@ -1224,8 +1224,10 @@ void UserInfoDlg::updateTab(const QStrin
currentTab = GeneralInfo;
btnMain3->setText(tr("&Update"));
btnMain2->setText(m_bOwner ? tr("Retrieve") : tr("&Save"));
+ btnMain1->setText(m_bOwner ? tr("&Save") : tr("&Menu"));
btnMain3->setEnabled(true);
btnMain2->setEnabled(true);
+ btnMain1->setEnabled(true);
if (!tabList[GeneralInfo].loaded)
SetGeneralInfo(NULL);
}
@@ -1233,8 +1235,10 @@ void UserInfoDlg::updateTab(const QStrin
{
btnMain3->setText(tr("&Update"));
btnMain2->setText(m_bOwner ? tr("Retrieve") : tr("&Save"));
+ btnMain1->setText(m_bOwner ? tr("&Save") : tr("&Menu"));
btnMain3->setEnabled(true);
btnMain2->setEnabled(true);
+ btnMain1->setEnabled(true);
currentTab = MoreInfo;
if (!tabList[MoreInfo].loaded)
SetMoreInfo(NULL);
@@ -1243,8 +1247,10 @@ void UserInfoDlg::updateTab(const QStrin
{
btnMain3->setText(tr("&Update"));
btnMain2->setText(m_bOwner ? tr("Retrieve") : tr("&Save"));
+ btnMain1->setText(m_bOwner ? tr("&Save") : tr("&Menu"));
btnMain3->setEnabled(true);
btnMain2->setEnabled(true);
+ btnMain1->setEnabled(true);
currentTab = WorkInfo;
if (!tabList[WorkInfo].loaded)
SetWorkInfo(NULL);
@@ -1253,8 +1259,10 @@ void UserInfoDlg::updateTab(const QStrin
{
btnMain3->setText(tr("&Update"));
btnMain2->setText(m_bOwner ? tr("Retrieve") : tr("&Save"));
+ btnMain1->setText(m_bOwner ? tr("&Save") : tr("&Menu"));
btnMain3->setEnabled(true);
btnMain2->setEnabled(true);
+ btnMain1->setEnabled(true);
currentTab = AboutInfo;
if (!tabList[AboutInfo].loaded)
SetAbout(NULL);
@@ -1263,8 +1271,10 @@ void UserInfoDlg::updateTab(const QStrin
{
btnMain3->setText(tr("Nex&t"));
btnMain2->setText(tr("P&rev"));
+ if (m_bOwner) btnMain1->setText("");
btnMain3->setEnabled(true);
btnMain2->setEnabled(true);
+ btnMain1->setEnabled(m_bOwner ? false : true);
currentTab = HistoryInfo;
if (!tabList[HistoryInfo].loaded)
SetupHistory();
@@ -1275,8 +1285,10 @@ void UserInfoDlg::updateTab(const QStrin
currentTab = LastCountersInfo;
btnMain3->setText("");
btnMain2->setText("");
+ btnMain1->setText(m_bOwner ? tr("&Save") : tr("&Menu"));
btnMain3->setEnabled(false);
btnMain2->setEnabled(false);
+ btnMain1->setEnabled(true);
if (!tabList[LastCountersInfo].loaded)
SetLastCountersInfo(NULL);
}
@@ -1329,7 +1341,12 @@ void UserInfoDlg::slotRetrieve()
}
else
{
- ShowHistoryNext();
+ if(m_bOwner)
+ {
+ ShowHistoryPrev();
+ } else {
+ ShowHistoryNext();
+ }
return;
}
