I'm afraid I'm still buried at work.(20-30% overtime the past year)
But if I get some quality time to code I'd gladly dive into it.
As a quick test, I recommend people to download jQuery 1.3 and rename it to
the one currently used by lift and see what happens.
If you have any problems regarding this.props, please search-n-replace it
with "jQuery.event.props" in the jquery-1.3.js-file
(Please note that jQuery 1.2.4 through 1.2.6 is plagued by a bug that causes
event.altKey to fail)
the fix I found on the web does something like this to fix it:
jQuery.event.fix = (function() { var oldFix = jQuery.event.fix;
return function(e) {
var ret = oldFix(e);
if(ret && ret.originalEvent)
ret.altKey = ret.originalEvent.altKey;
return ret; }
})();
if it works well as a drop-in-replacement we could theoretically add it to
lift 1.0 without adding support for the live()/die() functions etc until 1.1
Opinions?
Viktor
On Mon, Jan 19, 2009 at 2:13 PM, David Pollak <[email protected]
> wrote:
>
>
> On Mon, Jan 19, 2009 at 4:43 AM, Marius <[email protected]> wrote:
>
>>
>> I didn't do JQuery upgrades. Nonetheless looks like this upgrade would
>> impact Lift Ajax system (not quite the Lift API's) and it looks to me
>> that this needs thorough testing etc. Unfortunately right now I don't
>> have much bandwidth to take this on. I'd recommend working on this on
>> a separate branch until it is in a stable state. Tim/Viktor would it
>> be possible for you to take this on?
>>
>
> I'd suggest creating a branch with 1.3 and does testing/changing.
>
> 1.0 is pretty much going to be what Lift is today with fixes and
> performance enhancements. So, jQuery 1.3 will have to wait until after 1.0
> ships.
>
> Thanks,
>
> David
>
>
>>
>>
>> Br's,
>> Marius
>>
>> On Jan 19, 12:49 pm, Viktor Klang <[email protected]> wrote:
>> > On Mon, Jan 19, 2009 at 11:22 AM, Tim Perrett <[email protected]>
>> wrote:
>> > > Awesome Viktor,
>> >
>> > > What is the impact on the lift API if we upgraded?
>> >
>> > I had to replace "this.props" with "jQuery,event.props" in the minified
>> > version of 1.3 because I had FireBug give me a JavaScript error on the
>> > fix(e) - function
>> > Considering this, it should be a drop-in replacement (there might be
>> some
>> > quirks to churn out, but they are listed in the release docs).
>> >
>> > I highly recommend the new "live(trigger,func)" and "die(trigger,func)"
>> > system. (really speeds up ajax/comet content refreshes, from my
>> > observations).
>> >
>> > Who did the jQuery API integration? DaveB or Marius?
>> >
>> > Cheers,
>> > Viktor
>> >
>> >
>> >
>> >
>> >
>> > > Cheers, Tim
>> >
>> > > Sent from my iPhone
>> >
>> > > On 19 Jan 2009, at 10:19, Viktor Klang <[email protected]>
>> wrote:
>> >
>> > > Hey guys!
>> >
>> > > After upgrading from 1.2.3 to jQuery 1.3 on the company system, I can
>> > > really recommend lift to upgrade.
>> >
>> > > Here's some meaty reading: <http://docs.jquery.com/Release:jQuery_1.3
>> >
>> > >http://docs.jquery.com/Release:jQuery_1.3
>> >
>> > > The performance-gains are from my observations huge, but that's all
>> > > depending on usage. (of course)
>> >
>> > > Is this something we want to upgrade for the 1.0 release or do we want
>> to
>> > > wait until 1.1?
>> >
>> > > cheers,
>> >
>> > > --
>> > > Viktor Klang
>> > > Senior Systems Analyst
>> >
>> > --
>> > Viktor Klang
>> > Senior Systems Analyst
>>
>>
>
>
> --
> Lift, the simply functional web framework http://liftweb.net
> Collaborative Task Management http://much4.us
> Follow me: http://twitter.com/dpp
> Git some: http://github.com/dpp
>
>
> >
>
--
Viktor Klang
Senior Systems Analyst
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---
