On Fri, Jul 3, 2009 at 6:43 PM, David
Pollak<feeder.of.the.be...@gmail.com> wrote:
> Jeppe,
>
> Once I check in some code (in about 20 minutes), if you run Lift in Test
> mode (-Drun.mode=test), forms, etc. will have stable names which makes
> testing easier.

Thanks. I just tried this, and it seem something is not correct.
Here's a form field genrated by CRUDify:

<input  name="f00000000010000000_a0f86e3b78187b55b8628a66fb3371113ddc295c"
type="text" maxlength="2" value="DK" lift:field_name="vehicle:country"
/>

Firefox 3.5 complains about lift:field attribute.

Looking at the changes (and the example above) it seems that the field
name is still some psuedo random number. While this is better than
names changing between each request, I'm wondering if it's stable to
reordering & removing fields (my guess is no). It would be nice not to
change test cases just because we rearrange the form layout.

Moving forward, I'm not sure what the best solution is. I seem able to
specify the id attribute for forms that I create manually, but need
this also on CRUDify and other generated forms (and looking at the
above example, it seems it should be easy to eg. use the field_name).
In general, It would be nice for Lift to handle all this automatically
(as you've already started out to do), but if I have to add some
additional markup to make sure ids/names stay stable, I will prefer
that over test cases breaking if field ordering is changed.....

/Jeppe

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Lift" group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to