OK, I'm starting to dig into this and I'm finding that a lot of stuff in
TimeHelpers essentially replicates stuff that's already in JodaTime. Does
anyone see a problem with doing an overhaul of TimeHelpers in addition to
the Mapper stuff? I'll keep the API the same, it should just reduce a lot of
the actual impl code. For example, TimeHelpers.DateExtension exists purely
to allow a Date with a time of 00:00. The code will change from:

def noTime = {
      val calendar = Calendar.getInstance
      calendar.set(Calendar.HOUR_OF_DAY, 0)
      calendar.set(Calendar.MINUTE, 0)
      calendar.set(Calendar.SECOND, 0)
      calendar.set(Calendar.MILLISECOND, 0)
      calendar.getTime
}

to

def noTime = new DateTime().withTime(0,0,0,0)

Actually, I'm not sure that the original code is correct, either, since
DateExtension takes a Date parameter that is never used in the original
code.

Derek

On Fri, Oct 9, 2009 at 12:36 AM, Jeppe Nejsum Madsen <je...@ingolfs.dk>wrote:

>
> Derek Chen-Becker <dchenbec...@gmail.com> writes:
>
> > I'm planning on making the formatting easier to configure and also to
> move
> > the Mapper stuff to Joda Time. I know I keep saying this but I hope to
> start
> > working on this next week :P
>
> Awesome!
>
> /Jeppe
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Lift" group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to