I've created a ticket here: http://github.com/dpp/liftweb/issues/issue/322
Thanks again! - Aaron On Tue, Feb 2, 2010 at 10:10 PM, Peter Robinett <pe...@bubblefoundry.com> wrote: > You're welcome. I'm happy to look into adding Flot plugin support, but > please open a ticket on GitHub (http://github.com/dpp/liftweb/issues). > > Peter > > On Feb 1, 10:22 am, Aaron Valade <a...@alum.mit.edu> wrote: >> Thanks Peter! >> >> One of the other things that changed between Flot 0.4 and 0.6 is that >> a plugin structure was introduced and some functionality was pushed >> out of the core and into a plugin, specifically the selection >> functionality which can be used for zooming and other interactions >> with the charted data. I hate to tack on requests for more work, but >> if you get a chance, I'd appreciate if you could add functionality to >> the Lift Flot Widget to allow use of these plugins. I'm in the process >> of making some small changes with the Flot Widget to support these >> plugins in my local fork of Lift and would be happy to share what I've >> done, if that's allowed. Otherwise, I'd be very eager to provide >> additional testing of any capabilities that you make available or any >> other help that I can provide within the guidelines of the Lift >> project. >> >> Thanks, >> - A >> >> >> >> On Mon, Feb 1, 2010 at 12:28 PM, Peter Robinett <pe...@bubblefoundry.com> >> wrote: >> > Ok guys, I'll work on this in the next few days (I'm out of town right >> > now). >> >> > Peter >> >> > On Jan 31, 3:20 pm, Timothy Perrett <timo...@getintheloop.eu> wrote: >> >> It seems like peter will take ownership of this and make it happen >> >> ASAP so a patch / diff should not be needed. >> >> >> Peter, please confirm when you will roll this in a branch and put it >> >> on review board? >> >> >> Cheers, Tim >> >> >> Sent from my iPhone >> >> >> On 31 Jan 2010, at 22:48, Aaron Valade <aval...@gmail.com> wrote: >> >> >> > I'm more than happy to submit the patch under the Lift IP policy, >> >> > but I understand if you don't feel comfortable with that. And I can >> >> > submit it anyway that works for you. I'm just looking to help give >> >> > back to everyone that's helped me out. Albeit in a very, very small >> >> > way. >> >> >> > Sent from my iPhone >> >> >> > On Jan 31, 2010, at 5:43 PM, David Pollak <feeder.of.the.be...@gmail.com >> >> > > wrote: >> >> >> >> Peter, >> >> >> >> Please keep in mind the Lift IP policy. We don't pull from other >> >> >> repositories nor do we accept patches. We'll have to do the Flot >> >> >> 0.6 ourselves. >> >> >> >> Thanks, >> >> >> >> David >> >> >> >> On Fri, Jan 29, 2010 at 4:44 PM, Peter Robinett >> >> >> <pe...@bubblefoundry.com >> >> >> > wrote: >> >> >> Aaron, thanks so much for taking the initiative to upgrade Flot, it's >> >> >> something that I've been meaning to do. Just skimming over your >> >> >> changes, everything looks good. As for not using the packed excanvas >> >> >> file, that should be ok since Lift runs the YUI compressor by default >> >> >> on all Javascript files (correct, David?). Of course, broken URLs >> >> >> need >> >> >> to be fixed. >> >> >> >> David, how do we go about merging these changes? >> >> >> >> Peter >> >> >> >> On Jan 29, 3:32 pm, Aaron Valade <a...@alum.mit.edu> wrote: >> >> >> > There is one break that my commit made which I just realized >> >> >> after I >> >> >> > had sent this email in that I deleted the excanvas.pack.js file and >> >> >> > dropped in the excanvas.js that was included with the Flot 0.6 >> >> >> > distribution but didn't rename it to be excanvas.pack.js and didn't >> >> >> > change the path in the Flot.scala file. >> >> >> >> > I can make an additional commit that fixes this, if it pleases >> >> >> the court. :-) >> >> >> >> > - A >> >> >> >> > On Fri, Jan 29, 2010 at 6:15 PM, David Pollak >> >> >> >> > <feeder.of.the.be...@gmail.com> wrote: >> >> >> > > Peter, >> >> >> >> > > What do you think of the upgrade (given that you're the most >> >> >> Flot-ish Lift >> >> >> > > committer)? >> >> >> >> > > Thanks, >> >> >> >> > > David >> >> >> >> > > On Fri, Jan 29, 2010 at 12:32 PM, Aaron Valade >> >> >> <a...@alum.mit.edu> wrote: >> >> >> >> > >> Hello all, >> >> >> > >> I needed to use some of the recent functionality in the Flot >> >> >> jQuery >> >> >> > >> plugin which is version 0.6. The Flot lift-widget is >> >> >> currently at >> >> >> > >> 0.4. So I upgraded it to use the new version and I've posted >> >> >> the >> >> >> > >> commit on github: >> >> >> >> > >>http://github.com/avalade/liftweb/commit/fa3d76fb72a7f74d13265e4039f0 >> >> >> ... >> >> >> >> > >> Version 0.6 of Flot does make one breaking change which >> >> >> requires some >> >> >> > >> of the options which were previously described as a top level >> >> >> > >> attributes on the FlotOptions object to be pushed inside of a >> >> >> new >> >> >> > >> attribute called FlotSeriesOptions. I've made the appropriate >> >> >> changes >> >> >> > >> to the various example Flot charts which were included in the >> >> >> flotDemo >> >> >> > >> module. >> >> >> >> > >> Would it be possible to get this change upstream? >> >> >> >> > >> - Aaron >> >> >> >> > >> -- >> >> >> > >> You received this message because you are subscribed to the >> >> >> Google Groups >> >> >> > >> "Lift" group. >> >> >> > >> To post to this group, send email to lift...@googlegroups.com. >> >> >> > >> To unsubscribe from this group, send email to >> >> >> > >> liftweb+unsubscr...@googlegroups.com. >> >> >> > >> For more options, visit this group at >> >> >> > >>http://groups.google.com/group/liftweb?hl=en. >> >> >> >> > > -- >> >> >> > > Lift, the simply functional web frameworkhttp://liftweb.net >> >> >> > > Beginning Scalahttp://www.apress.com/book/view/1430219890 >> >> >> > > Follow me:http://twitter.com/dpp >> >> >> > > Surf the harmonics >> >> >> >> > > -- >> >> >> > > You received this message because you are subscribed to the >> >> >> Google Groups >> >> >> > > "Lift" group. >> >> >> > > To post to this group, send email to lift...@googlegroups.com. >> >> >> > > To unsubscribe from this group, send email to >> >> >> > > liftweb+unsubscr...@googlegroups.com. >> >> >> > > For more options, visit this group at >> >> >> > >http://groups.google.com/group/liftweb?hl=en. >> >> >> >> -- >> >> >> You received this message because you are subscribed to the Google >> >> >> Groups "Lift" group. >> >> >> To post to this group, send email to lift...@googlegroups.com. >> >> >> To unsubscribe from this group, send email to >> >> >> liftweb+unsubscr...@googlegroups.com >> >> >> . >> >> >> For more options, visit this group >> >> >> athttp://groups.google.com/group/liftweb?hl=en >> >> >> . >> >> >> >> -- >> >> >> Lift, the simply functional web frameworkhttp://liftweb.net >> >> >> Beginning Scalahttp://www.apress.com/book/view/1430219890 >> >> >> Follow me:http://twitter.com/dpp >> >> >> Surf the harmonics >> >> >> -- >> >> >> You received this message because you are subscribed to the Google >> >> >> Groups "Lift" group. >> >> >> To post to this group, send email to lift...@googlegroups.com. >> >> >> To unsubscribe from this group, send email to >> >> >> liftweb+unsubscr...@googlegroups.com >> >> >> . >> >> >> For more options, visit this group >> >> >> athttp://groups.google.com/group/liftweb?hl=en >> >> >> . >> >> > -- >> >> > You received this message because you are subscribed to the Google >> >> > Groups "Lift" group. >> >> > To post to this group, send email to lift...@googlegroups.com. >> >> > To unsubscribe from this group, send email to >> >> > liftweb+unsubscr...@googlegroups.com >> >> > . >> >> > For more options, visit this group >> >> > athttp://groups.google.com/group/liftweb?hl=en >> >> > . >> >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "Lift" group. >> > To post to this group, send email to lift...@googlegroups.com. >> > To unsubscribe from this group, send email to >> > liftweb+unsubscr...@googlegroups.com. >> > For more options, visit this group >> > athttp://groups.google.com/group/liftweb?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to lift...@googlegroups.com. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
