If anyone has a way to have a custom Buffer that wraps a List var (or another approach that OneToMany and ManyToMany can use) that works on 2.7 and 2.8, I'm all ears. Meanwhile if you like you can revert the commit. In any case I commented very clearly which lines were commented out or added for 2.8, as you may have seen.
------------------------------------- Indrajit Raychaudhuri<indraj...@gmail.com> wrote: Hey Naftoli, Man, it would be great *not to* mix up 2.7 and 2.8 codes inline. Keeping it in sync with master would get very confusing and error prone (personally I don't find that aesthetically pleasing either). In fact, with some adjustment, it's possible to have parts of code friendly with both 2.7 and 2.8. That way, we'll have smaller delta to manage between the branches. If necessary, feel free to reopen #313 and backport as much as possible. Cheers, Indrajit On 10/02/10 9:59 AM, Naftoli Gugenheim wrote: > Never mind, apparently I wasn't up to date. > > On Tue, Feb 9, 2010 at 11:20 PM, Naftoli Gugenheim <naftoli...@gmail.com > <mailto:naftoli...@gmail.com>> wrote: > > I got OneToMany to compile (not in a way that would work on 2.7 though). > Then I tried to push it: > naft...@naftoli-pc /c/dev/gitrepo/liftweb (280_port_refresh) > $ git rebase origin/280_port_refresh > Current branch 280_port_refresh is up to date. > > naft...@naftoli-pc /c/dev/gitrepo/liftweb (280_port_refresh) > $ git push origin 280_port_refresh > To g...@github.com:dpp/liftweb.git > ! [rejected] 280_port_refresh -> 280_port_refresh (non-fast > forward) > error: failed to push some refs to 'g...@github.com:dpp/liftweb.git' > > naft...@naftoli-pc /c/dev/gitrepo/liftweb (280_port_refresh) > $ > > Actually I only did the rebase to be sure, after I had already > gotten the 'non-fast forward' error. What am I doing wrong? > > As far as ManyToMany, I can't work on it because the compiler seems > to just freeze (using up CPU though). I assume that means there's a > compiler bug involved. > > Thanks. > > > On Tue, Feb 9, 2010 at 5:46 PM, David Pollak > <feeder.of.the.be...@gmail.com > <mailto:feeder.of.the.be...@gmail.com>> wrote: > > > > On Tue, Feb 9, 2010 at 2:28 PM, Naftoli Gugenheim > <naftoli...@gmail.com <mailto:naftoli...@gmail.com>> wrote: > > Could you give me exact instructions what to do to test my > code on 2.8? > > > git checkout -b 280_port_refresh origin/280_port_refresh > cd framework/lift-persistence/lift-mapper > emacs $(grep -l "FIXME: 280" $(find . -name *.scala)) > > remove the comments around your code. Make it compile and pass > the existing tests. > > Thanks. > > 2010/2/7 David Pollak <feeder.of.the.be...@gmail.com > <mailto:feeder.of.the.be...@gmail.com>> > > > > On Sun, Feb 7, 2010 at 1:01 PM, Naftoli Gugenheim > <naftoli...@gmail.com <mailto:naftoli...@gmail.com>> wrote: > > So if I get around to it would it indeed be > preferable to point it to SHtml? > > > Changing the code is one of the lowest priorities I > could imagine. I would say that closing the stuff > you've had on review board for > 1 months would be much > higher priority. Adding copyright notices and other > headers to the code you've written in Lift is a higher > priority. Helping to port your code to 2.8 would be a > higher priority. > > > ------------------------------------- > David Pollak<feeder.of.the.be...@gmail.com > <mailto:feeder.of.the.be...@gmail.com>> wrote: > > On Sun, Feb 7, 2010 at 12:47 PM, Naftoli Gugenheim > <naftoli...@gmail.com > <mailto:naftoli...@gmail.com>>wrote: > > > Hello. Why do Mapper's toForm implementations use > S.fmapFunc directly > > rather than using SHtml? Is it not duplicate code? > > > > Because the Mapper code was the earliest Lift > code... written long before > SHtml. > > > > Thanks. > > > > -- > > You received this message because you are > subscribed to the Google Groups > > "Lift" group. > > To post to this group, send email to > liftweb@googlegroups.com > <mailto:liftweb@googlegroups.com>. > > To unsubscribe from this group, send email to > > liftweb+unsubscr...@googlegroups.com > > <mailto:liftweb%2bunsubscr...@googlegroups.com><liftweb%2bunsubscr...@googlegroups.com > <mailto:liftweb%252bunsubscr...@googlegroups.com>> > > . > > For more options, visit this group at > > http://groups.google.com/group/liftweb?hl=en. > > > > > > > -- > Lift, the simply functional web framework > http://liftweb.net > Beginning Scala > http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Surf the harmonics > > -- > You received this message because you are subscribed > to the Google Groups "Lift" group. > To post to this group, send email to > liftweb@googlegroups.com > <mailto:liftweb@googlegroups.com>. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com > <mailto:liftweb%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > -- > > You received this message because you are subscribed > to the Google Groups "Lift" group. > To post to this group, send email to > liftweb@googlegroups.com > <mailto:liftweb@googlegroups.com>. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com > <mailto:liftweb%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > > > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Surf the harmonics > > -- > You received this message because you are subscribed to > the Google Groups "Lift" group. > To post to this group, send email to > liftweb@googlegroups.com <mailto:liftweb@googlegroups.com>. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com > <mailto:liftweb%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > > -- > You received this message because you are subscribed to the > Google Groups "Lift" group. > To post to this group, send email to > liftweb@googlegroups.com <mailto:liftweb@googlegroups.com>. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com > <mailto:liftweb%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > > > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Surf the harmonics > > -- > You received this message because you are subscribed to the > Google Groups "Lift" group. > To post to this group, send email to liftweb@googlegroups.com > <mailto:liftweb@googlegroups.com>. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com > <mailto:liftweb%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > > > -- > You received this message because you are subscribed to the Google > Groups "Lift" group. > To post to this group, send email to lift...@googlegroups.com. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en. -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
