- **Patch**: review --> needs_work
- **Comment**:

The discussion on this in both Rietveld and in emails indicates that this still 
needs some work.

See: https://lists.gnu.org/archive/html/lilypond-devel/2018-04/msg00096.html 
(re parser in general)

and then 
https://lists.gnu.org/archive/html/lilypond-devel/2018-04/msg00113.html and 
finally https://lists.gnu.org/archive/html/lilypond-devel/2018-04/msg00115.html 
(the main thread for the discussion of the actual patch proposed).



---

** [issues:#5314] Syntax: lyric_mode_music might be a MUSIC_FUNCTION**

**Status:** Started
**Created:** Wed Apr 25, 2018 06:28 AM UTC by Knut Petersen
**Last Updated:** Wed Apr 25, 2018 08:41 AM UTC
**Owner:** Knut Petersen


Syntax: lyric_mode_music might be a MUSIC_FUNCTION

With this patch, all four scores in the lilypond
source below use a valid syntax and produce correct
output.

Without this patch only the first two scores use
a valid syntax (an extra pair of curly brackets
would fix the problem).

  \version "2.21.0"

  music = \relative { c''2 2 }
  lyrics_dir = \lyricmode { foo bar }
  lyrics_fun = #(define-music-function () ()
                 #{ \lyricmode { foo bar } #})

  \score {\music \addlyrics { foo bar } \layout {}}
  \score {\music \addlyrics \lyrics_dir \layout {}}
  \score {\music \addlyrics \lyrics_fun \layout {}}
  \score {\music \addlyrics \displayLilyMusic
                            \lyrics_fun \layout {}}

Signed-off-by: Knut Petersen <knut_peter...@t-online.de>

http://codereview.appspot.com/343820043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to