- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
commit aec018d7d4ed58e6d67e4621019a6cf2936b212f (HEAD ->
pushed/issue-5336-grob-array-downcasting, origin/staging)
Author: Dan Eble <nine.fierce.ball...@gmail.com>
Date: Mon Jun 4 17:51:24 2018 -0400
Issue 5336: Remove downcasting methods from Grob_array and Grob_info
Presenting dynamic casts as simple getters was hiding something that
is better left in the open.
---
** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Sun Jun 10, 2018 03:16 PM UTC
**Owner:** Dan Eble
There are methods of `Grob_array` and `Grob_info` which are basically dynamic
casts with the added cost of a function call.
~~~
Item *
Grob_array::item (vsize i)
{
return dynamic_cast<Item *> (grobs_.at (i));
}
~~~
Making this operation more convenient to type is a rather perverse incentive.
These methods should probably be abolished.
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
