This wasn't private at all since I actually had added this very example to the 
regtests:
input/regression/skyline-grob-rotation.ly
It should have shown up in the standard regtest procedures, I'll check this.

By the way: grob rotation (the printed stencil) uses rotate_degrees, i.e. the 
offset co-ordinates are "measured in terms of the extent of the stencil, so -1 
= LEFT/DOWN edge, 1 = RIGHT/UP edge." (cited from a comment in the coding).

This was the reason that drove me into rotating a copy of the stencil using 
rotate_degrees as an easy way to get the exact same behaviour for skylines and 
the printed stencil later on. Unfortunately, I was totally ignorant of garbage 
collection.


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to