- Description has changed:

Diff:

~~~~



~~~~

- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5366] Move warnings out of find/create context functions**

**Status:** Started
**Created:** Mon Jul 02, 2018 11:26 PM UTC by Dan Eble
**Last Updated:** Mon Jul 02, 2018 11:26 PM UTC
**Owner:** Dan Eble


Move warnings out of find/create context functions

The motivation for this is that Context::find_create_context () and
find_context_near () should probably be merged for maintainability,
but one of the differences between them that must be dealt with is
that find_create_context () logs when it fails and find_context_near
() does not.  Adding warnings to find_context_near () risks being too
noisy, leaving the option taken here.

The new method Context::diagnostic_id (name, id) returns a formatted
string (e.g. "Voice" or "Voice = mel") for use in a log message.  It
is used for the warnings that are being moved as well as few other
existing warnings to increase consistency.

http://codereview.appspot.com/349740043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to