- **assigned_to**: pkx166h --> Valentin Villenave
- **Needs**: -->
- **Type**: --> Enhancement
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Started
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Sat Dec 15, 2018 01:51 AM UTC
**Owner:** Valentin Villenave
On 13/08/15 21:42, Malte Meyn wrote:
> Hi list,
>
> the case of the ‘c’ in partcombine is inconsistent, confusing me every
> time I use \partcombine(Apart|Chords|…):
>
> \partcombine, \partcombineApart, … but
> \partCombineTextsOnNote, \partCombineListener
>
> I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’.
>
> Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the
> engravers which use the more ‘natural’ underscore instead of camelCase
> for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that
> ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not
> ‘cueclefGlyph’), ‘Part_combine_engraver’ does.
>
> I think that this would be rather easy to change.
>
> Cheers,
> Malte
Response to Issue #4603: Syntax change from all instances "partcombine" to
"partCombine" and convert-ly rule added to go along with.
http://codereview.appspot.com/323040043 - part 1 of 3
http://codereview.appspot.com/326870043 - part 2 of 3
http://codereview.appspot.com/327970043 - part 3 of 3
Note this will require both a convert.ly and a makelsr.py run to make sure that
the patch passes all the tests.
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
