- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for Dec 24th



---

** [issues:#5258] Vertical breve rest position in TabStaff/RhythmicStaff**

**Status:** Started
**Created:** Sat Jan 13, 2018 04:47 PM UTC by Malte Meyn
**Last Updated:** Mon Dec 17, 2018 12:03 PM UTC
**Owner:** Malte Meyn
**Attachments:**

- 
[Regtest1.png](https://sourceforge.net/p/testlilyissues/issues/5258/attachment/Regtest1.png)
 (16.1 kB; image/png)
- 
[Regtest2.png](https://sourceforge.net/p/testlilyissues/issues/5258/attachment/Regtest2.png)
 (187.3 kB; image/png)
- 
[breve_rests.png](https://sourceforge.net/p/testlilyissues/issues/5258/attachment/breve_rests.png)
 (26.0 kB; image/png)
- 
[gould_breve_rests_oneline.png](https://sourceforge.net/p/testlilyissues/issues/5258/attachment/gould_breve_rests_oneline.png)
 (27.9 kB; image/png)
- 
[regtest3.png](https://sourceforge.net/p/testlilyissues/issues/5258/attachment/regtest3.png)
 (570.0 kB; image/png)


https://codereview.appspot.com/332640043

According to Gould breve rests should hang from a one line staff 
(RhythmicStaff) as semibreve rests do. Also, there is a comment in 
multi-measure-rest.cc saying
```
// Staff position is somewhat icky regarding its definition for
// compatibility reasons.  It is intended to be the baseline of
// a breve rest.  However, when the staff space is more than
// single space (like with tablature), it looks better if all
// rests are actually hanging.  So staff position, in reality,
// is the semi-breve position - 2.  Everything else is
// calculated from there.
```
This confirms what Gould writes. But the code applies only to MMRs with a 
measure-count > 1.

That leads to inconsistent behaviour: MultiMeasureRest breve glyphs hang, but 
not for single measures. Rest breve glyphs don’t hang. Instead, all breve rests 
should hang.
```
\version "2.19.80"

music = {
  \compressFullBarRests
  r1 R1 R\breve
  \time 4/2
  r\breve R\breve R\longa
  \time 8/2
  r\longa R\longa
}

\new TabStaff \with { \tabFullNotation } \music

\new RhythmicStaff \music

\new Staff \music
```


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to