- **Patch**: new --> review
- **Comment**:
Passes make, make check and a full make doc.
Reg test diffs are here:
https://nc-cluster02.yourownnet.cloud/index.php/s/YaYQnQs5Je7xc5Z
---
** [issues:#5224] Update EventChord to include a ChordSemantics event entry
which captures input semantic information from chord mode and uses it to create
chord names.**
**Status:** Started
**Created:** Wed Nov 01, 2017 02:07 AM UTC by Charles Winston
**Last Updated:** Tue Apr 02, 2019 08:54 PM UTC
**Owner:** Carl Sorensen
Update EventChord to include a ChordSemantics event entry which captures input
semantic information from chord mode and uses it to create chord names.
Without these semantics, naming chords based only on their notes results in
ambiguous naming:
Example: Cm7 no root and Eb both have the exact same notes, and so there is no
way to differentiate between them, unless we capture the data from chord mode:
{ cm:7.1 } as opposed to { eb }
A new patchset has been loaded at
https://codereview.appspot.com/568650043
The original patchset can be found at
https://codereview.appspot.com/337870043
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto