- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

Pushed to staging as
~~~
commit f48acb57747f3925c90c41ad6c7bc04c00104015
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Sat Dec 21 14:00:27 2019 +0100

    Issue 5653/6: Delete no-builtin-rules.make
    
    The implicit rules are only used if no other rule can be found. We
    define all needed rules ourselves, so they should not harm.

commit b2bd874f5520a913058f7963bc467ace143565da
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Sat Dec 21 13:17:51 2019 +0100

    Issue 5653/5: Delete flower/VERSION
    
    This is very old and I don't think this file is used. Also get rid
    of FLOWER_VERSION and FULL_FLOWER_VERSION which aren't used either.

commit f203a1c508e38c5e22cb2ead5a66efe27780f81a
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Sat Dec 21 13:12:49 2019 +0100

    Issue 5653/4: Simplify python/GNUmakefile
    
    OUT_SO_MODULES and OUT_PYC_MODULES don't exist anymore.

commit 4681522edc5d41ae03830d5d8870803b10d3ac01
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Mon Dec 23 12:24:26 2019 +0100

    Issue 5653/3: Drop support for compiling C files
    
    All source code is C++ by now, move the used rules to c++-*.make.

commit 22b862e0124fb63baae48bc30952b4f27938d494
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Sat Dec 21 12:54:50 2019 +0100

    Issue 5653/2: Drop unused stepmake templates
    
    A list of needed one can be obtained by the following:
     $ git grep "STEPMAKE_TEMPLATES.*=" | sed "s/.*=\W*\(.*\)/\1/" | \
          tr ' ' '\n' | sort -u | grep -v "\\\$"
    
    However we cannot simply delete all others because some are referenced
    elsewhere, so it's a manual process of checking the candidates.

commit e3764d619fa89b1a9df957e0e6085bab84c37a9f
Author: Jonas Hahnfeld <hah...@hahnjo.de>
Date:   Sat Dec 21 12:27:51 2019 +0100

    Issue 5653/1: Remove line break from STEPMAKE_TEMPLATES
    
    It's easier to analyze when all values are in a single line.
~~~



---

** [issues:#5653] Cleanup unneeded parts of Stepmake**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Wed Jan 08, 2020 03:04 PM UTC by Jonas Hahnfeld
**Last Updated:** Tue Jan 14, 2020 09:41 AM UTC
**Owner:** Jonas Hahnfeld


Cleanup unneeded parts of Stepmake

Individual changes:
1. Remove line break from STEPMAKE_TEMPLATES

It's easier to analyze when all values are in a single line.

2. Drop unused stepmake templates

A list of needed one can be obtained by the following:
 $ git grep "STEPMAKE_TEMPLATES.*=" | sed "s/.*=\W*\(.*\)/\1/" | \
      tr ' ' '\n' | sort -u | grep -v "\\\$"

However we cannot simply delete all others because some are referenced
elsewhere, so it's a manual process of checking the candidates.

3. Drop support for compiling C files

All source code is C++ by now, move the used rules to c++-*.make.

4. Simplify python/GNUmakefile

OUT_SO_MODULES and OUT_PYC_MODULES don't exist anymore.

5. Delete flower/VERSION

This is very old and I don't think this file is used. Also get rid
of FLOWER_VERSION and FULL_FLOWER_VERSION which aren't used either.

6. Delete no-builtin-rules.make

The implicit rules are only used if no other rule can be found. We
define all needed rules ourselves, so they should not harm.

http://codereview.appspot.com/577280043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to