Thanks for testing, this process is incredibly helpful! Unfortunately I can't 
figure out how to make this work in Python 2 without still needing changes for 
Python 3 :-( so I guess I'll just put this on my growing list of incompatible 
changes that need to be added after after running 2to3...


---

** [issues:#5663] Encoding preparations for Python 3.5**

**Status:** Started
**Created:** Wed Jan 15, 2020 09:42 PM UTC by Jonas Hahnfeld
**Last Updated:** Fri Jan 17, 2020 08:52 AM UTC
**Owner:** Jonas Hahnfeld


Encoding preparations for Python 3.5

1. Use codecs.open() to decode as utf-8

This is in preparation for Python 3.5 where the default encoding
depends on the value of the LANG environment variable. As far as
I can tell, this was changed later on and at least Python 3.7 and
version 3.8 always default to 'utf-8' on Linux. As I'm proposing to
make Python 3.5 the required minimum, we can't rely on this and need
to force 'utf-8' when reading files that could contain Unicode.

2. musicxml2ly: Correct usage of codecs module

sys.stdout is already in lilylib and codecs.open() always opens
a file in binary mode.

3. lilylib: Remove encoded_write

It's not needed anymore as sys.stdout and sys.stderr are wrapped
with encoding writers. (The argument file for show_rules in script
convert-ly is also sys.stdout.)

http://codereview.appspot.com/551340043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

Reply via email to