"Jonas Hahnfeld" <hah...@users.sourceforge.net> writes:
> I only changed one string, please consider skipping another "review" phase.
James' job is primarily implementing a process, not having to make
decisions. If you consider skipping a step is warranted and you are
going to take responsibility for it, spell it out and do so.
It's worth noting that when Texinfo markup comes into play, inadvertant
misspellings may render documentation uncompilable. A change only in
text tends to be harmless in comparison.
--
David Kastrup
---
** [issues:#5690] Tiny fixes for extractpdfmark**
**Status:** Started
**Created:** Sat Jan 25, 2020 08:46 AM UTC by Jonas Hahnfeld
**Last Updated:** Mon Jan 27, 2020 07:38 AM UTC
**Owner:** Jonas Hahnfeld
Tiny fixes for extractpdfmark
Individual changes:
1) Fix extractpdfmark not coming from PATH
If STEPMAKE_PROGS cannot find an optional program, it returns "false".
Checking for this value is better than requiring exactly "extractpdfmark"
which does not hold if the program is not in PATH and the user explicitly
sets the environment variable EXTRACTPDFMARK.
2) Fix extractpdfmark with GhostScript 9.50
GhostScript 9.50 defaults to -dSAFE, so the build system needs to pas
in -dNOSAFE explicitly.
3) Update message for optional extractpdfmark
>From my experiments, enabling extractpdfmark rather increases the
required disk space. This is probably because the process produces
additional intermediate files. It only benefits the final PDF docs.
http://codereview.appspot.com/571420055
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
