- **Patch**: countdown --> push
- **Comment**:
Patch counted down - please push
---
** [issues:#5694] Dot_configuration maintenance**
**Status:** Started
**Created:** Sat Jan 25, 2020 04:12 PM UTC by Dan Eble
**Last Updated:** Mon Jan 27, 2020 11:29 AM UTC
**Owner:** Dan Eble
1: iterate properly in reverse
The previous code would have malfunctioned for an empty container.
2: swap instead of copy
3: reduce repetition using a lambda function
4: use range-for loops
5: Dot_configuration "has a" instead of "is a" std::map
It is considered poor form to create subclasses of standard containers
because they lack virtual destructors. Inheriting privately from
std::map avoids potential problems by preventing Dot_configuration from
being treated as a std::map from the outside. (I didn't find any actual
problems in this case.)
Limiting the Dot_configuration interface to just the map methods that
are actually used makes it easier to understand how Dot_configuration is
used without searching the entire code.
https://codereview.appspot.com/577380046
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto