- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

```text
commit ee162c3ea7894868d1dee6b2af5f32a17ebdbd71
Author: Dan Eble <nine.fierce.ball...@gmail.com>
Date:   Thu Jun 28 19:56:29 2018 -0400

    Issue 5362/3: Change descend-only to search-direction
    
    It is now a direction rather than a boolean.
```
```text
commit 9c203228cf6b6f7173182d8d935337ef26544ea9
Author: Dan Eble <nine.fierce.ball...@gmail.com>
Date:   Wed Jan 22 14:33:39 2020 -0500

    Issue 5362/2: Generalize context searches
    
    Combine code for \new, \context, and various internal searches.  This
    includes a small block of disabled code which will fix
    input/regression/context-find-parent.ly once it is enabled.
    
    input/regression/context-descend-only-not-found.ly shows that a defect
    in the descend-to-context function has been fixed: although the previous
    implementation never changed context outside the current subtree, it
    allowed creating a new context outside the current subtree.
```
```text
commit 65be669464d1e8ac59d8d9470c344ef74e1d6aa4
Author: Dan Eble <nine.fierce.ball...@gmail.com>
Date:   Wed Jan 8 17:28:52 2020 -0500

    Issue 5362/1: Add Context::matches ()
    
    This method answers the central question of a context search: is this
    what I'm looking for?  Its use will increase in later commits.
```



---

** [issues:#5362] Generalize context searches**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Fri Jun 29, 2018 01:08 AM UTC by Dan Eble
**Last Updated:** Tue Feb 04, 2020 06:15 AM UTC
**Owner:** Dan Eble


1: Add Context::matches ()

This method answers the central question of a context search: is this
what I'm looking for?  Its use will increase in later commits.

2: Generalize context searches

Combine code for \new, \context, and various internal searches.  This
includes a small block of disabled code which will fix
input/regression/context-find-parent.ly once it is enabled.

input/regression/context-descend-only-not-found.ly shows that a defect
in the descend-to-context function has been fixed: although the
previous implementation never changed context outside the current
subtree, it allowed creating a new context outside the current
subtree.

3: Change descend-only to search-direction

It is now a direction rather than a boolean.

Current review: https://codereview.appspot.com/579250043/
Old review: <strike> http://codereview.appspot.com/344050043 </strike>


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to