Ok, I was squeamish about this issue because I did not know to what degree it
works and what is missing. Here are the problems to expect:
a) outdated size estimates for unreachable links in the offline HTML
documentation will disappear
b) outdated size estimates on the website may disappear irrespective of
reachability: I just have no idea how the website generation works.
Reinstating basic support is likely a one-liner in some script or setup file
Problem a) is a straightforward improvement making it _much_ easier for
translators to diagnose our current problems with translated links.
Problem b) is a moderate regression not causing functional damage to the live
web pages and being a good reference point for making the size links work in
the webpage.
It is a bit unfortunate that so far nobody could be bothered about what I might
have been missing about the expected problem b) and where it needs to get
addressed. Letting the proverbial silt hit the fan may be what it takes, and
the damage is confined. People will no longer get warned about the notation
manual being 30MB in size before they download it, but then it actually is
something like 6.5MB in size, so that warning is of moderate usefulness. The
warnings for the big-page HTML are probably less absurdly wrong. But I doubt
many people download those.
In summary, it seems more worthwhile to go ahead rather than to refrain.
Unless of course relevant input arrives on the code review that allows to
improve things even before continuing.
---
** [issues:#5822] Calculate download sizes rather than hardcoding them**
**Status:** Started
**Created:** Fri Mar 06, 2020 01:19 AM UTC by David Kastrup
**Last Updated:** Sat Mar 07, 2020 03:40 AM UTC
**Owner:** David Kastrup
Calculate download sizes rather than hardcoding them
This has several problems yet. The most relevant problem may be that
I have no clue how our actual webpages are being compiled, so this
likely would render the web pages silent about download sizes.
It works on the offline-root web pages intended as HTML documentation.
However, at the completion of make doc, numerous files are flagged as
not being available for size calculations. This is not really a
problem with this patch: it turns out that the respective links would
actually all be dead. So this is something that should be fixed
independently.
In contrast, the live webpage may have some links where the script
complains that aren't dead as much as dependent on the browser's
language settings (which is a bad idea since it does not allow
browsing documentation that does not correspond to your selected
browser language).
Contains two commits:
Replace hardwired download sizes with HTML comment
Download sizes given in web page and HTML pages tended to have
diverged a lot from reality. This patch removes all of the download
sizes but adds special HTML comments into the HTML files that
previously contained size estimates. These comments can then be
replaced by the actual sizes with a postprocessing script.
As a consequence, PDF and Info versions now no longer contain download
size estimates.
Replace HTML size comments with human-readable size
This calculates download sizes as the last step of HTML generation and
puts them into the HTML files for reference.
The work is done by scripts/build/fix-docsize.sh .
It does that by replacing the size-requesting HTML comments in the
files given on the command line by the respective human-readable size.
scripts/build/fix-docsize.sh is run in the respective directories as
the final step of generating the HTML versions.
This script uses ls -sh in order to get a human-readable size spec.
http://codereview.appspot.com/567340043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
