- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
commit ee197383f4af552ed433c496617cb5ffe2a28dcf
Author: David Kastrup <[email protected]>
AuthorDate: Wed Feb 26 02:07:27 2020 +0100
Commit: David Kastrup <[email protected]>
CommitDate: Wed Mar 11 18:25:21 2020 +0100
Issue 5822/2: Replace HTML size comments with human-readable size
This calculates download sizes as the last step of HTML generation and
puts them into the HTML files for reference.
The work is done by scripts/build/fix-docsize.sh .
It does that by replacing the size-requesting HTML comments in the
files given on the command line by the respective human-readable size.
scripts/build/fix-docsize.sh is run in the respective directories as
the final step of generating the HTML versions.
This script uses ls -sh in order to get a human-readable size spec.
commit 1c1b076adf7458ff90efb3766ef46cba026b0af6
Author: David Kastrup <[email protected]>
AuthorDate: Thu Mar 5 23:47:18 2020 +0100
Commit: David Kastrup <[email protected]>
CommitDate: Wed Mar 11 18:25:21 2020 +0100
Issue 5822/1: Replace hardwired download sizes with HTML comment
Download sizes given in web page and HTML pages tended to have
diverged a lot from reality. This patch removes all of the download
sizes but adds special HTML comments into the HTML files that
previously contained size estimates. These comments can then be
replaced by the actual sizes with a postprocessing script.
As a consequence, PDF and Info versions now no longer contain download
size estimates.
~~~
---
** [issues:#5822] Calculate download sizes rather than hardcoding them**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Fri Mar 06, 2020 01:19 AM UTC by David Kastrup
**Last Updated:** Wed Mar 11, 2020 06:51 AM UTC
**Owner:** David Kastrup
Calculate download sizes rather than hardcoding them
This has several problems yet. The most relevant problem may be that
I have no clue how our actual webpages are being compiled, so this
likely would render the web pages silent about download sizes.
It works on the offline-root web pages intended as HTML documentation.
However, at the completion of make doc, numerous files are flagged as
not being available for size calculations. This is not really a
problem with this patch: it turns out that the respective links would
actually all be dead. So this is something that should be fixed
independently.
In contrast, the live webpage may have some links where the script
complains that aren't dead as much as dependent on the browser's
language settings (which is a bad idea since it does not allow
browsing documentation that does not correspond to your selected
browser language).
Contains two commits:
Replace hardwired download sizes with HTML comment
Download sizes given in web page and HTML pages tended to have
diverged a lot from reality. This patch removes all of the download
sizes but adds special HTML comments into the HTML files that
previously contained size estimates. These comments can then be
replaced by the actual sizes with a postprocessing script.
As a consequence, PDF and Info versions now no longer contain download
size estimates.
Replace HTML size comments with human-readable size
This calculates download sizes as the last step of HTML generation and
puts them into the HTML files for reference.
The work is done by scripts/build/fix-docsize.sh .
It does that by replacing the size-requesting HTML comments in the
files given on the command line by the respective human-readable size.
scripts/build/fix-docsize.sh is run in the respective directories as
the final step of generating the HTML versions.
This script uses ls -sh in order to get a human-readable size spec.
http://codereview.appspot.com/567340043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
