- **Patch**: push --> needs_work
- **Type**: Enhancement --> Maintainability
- **Comment**:
Well, basically this was done as an illustration. For a full-blown change, it
would also want to cover define-markup-list-command and there has been no
feedback from Han-Wen who requested illustrating my proposal. So needs_work
for now.
---
** [issues:#5895] define-markup-command-internal ->
module-define-markup-command!**
**Status:** Started
**Created:** Sun Apr 12, 2020 12:58 PM UTC by David Kastrup
**Last Updated:** Fri Apr 17, 2020 08:11 AM UTC
**Owner:** David Kastrup
define-markup-command-internal -> module-define-markup-command!
Tangible benefits of this approach are not all that clear, and it
doesn't cover define-markup-list-command in the current form either,
so it warrants more work before committing or even deciding to commit.
Particularly so since for convenience it reverts a previous patch
combining the internals of define-markup-command and
define-markup-list-command, in order to illustrate the approach just
on the former.
However, it works and provides a basis for discussion. The principal
idea is to provide a version of define-markup-command that is not
specific to the current module and not a macro, in a similar vein to
how module-define! complements define , and use this in the parser
rather than the previous somewhat fuzzier
define-markup-command-internal .
Additional commits:
Add Lily_lexer::current_scope () function
Revert "Express define-markup-list-command-internal using
define-markup-command-internal"
This reverts commit 9f1683921621b612b94080d506ee317b058b29c8.
http://codereview.appspot.com/547920045
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
