- **labels**: --> Fixed_2_21_1
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
commit a456a5946c21cb63c64640a758e7faf829d98fa2
Author: Han-Wen Nienhuys <han...@lilypond.org>
AuthorDate: Mon Apr 13 20:57:51 2020 +0200
Commit: Han-Wen Nienhuys <han...@lilypond.org>
CommitDate: Sun Apr 19 09:59:34 2020 +0200
Copy alist instead of deep copy on Grob clone
On the MSDM score, ly_deep_copy takes 1.58% of runtime according a
gprof. Removing it shows a consistent 1.4% improvement in user
time.
The deep copy was introduced together with the separation of object
properties and value properties. This is because the Grob substition
did a recursive rewrite of the entire mutable alist, and the
equivalent for value (ie. non-object) properties is to do a deep copy.
The deep copy does not really solve a problem, because the reader
calling get_property cannot distinguish grob-local values from
immutable, shared values. The sort of modification that a deep copy
protects against would modify the shared data in this case, leading to
bugs.
~~~
---
** [issues:#5906] Copy alist instead of deep copy on Grob clone**
**Status:** Fixed
**Labels:** Fixed_2_21_1
**Created:** Mon Apr 13, 2020 06:58 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sun Apr 19, 2020 06:49 AM UTC
**Owner:** Han-Wen Nienhuys
https://codereview.appspot.com/561640045
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
