- **labels**:  --> Fixed_2_21_1
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Type**:   --> Maintainability
- **Comment**:

Pushed to staging as
commit 0f64ac01bd6ee864251a5aaf19f128eb54810330
Author: David Kastrup <d...@gnu.org>
Date:   Sat Apr 18 13:46:57 2020 +0200

    Issue 5916/3: Remove/move obviated includes of listener.hh

commit c5e9f74048e5cbd2ce63e351a627e8a9c4dbb67b
Author: David Kastrup <d...@gnu.org>
Date:   Sat Apr 18 12:15:18 2020 +0200

    Issue 5916/2: Remove Smob_core::get_listener function
    
    This unties Listeners from the Smob_core functionality.  One tangible 
benefit
    is that listener.hh does no longer need to get included as part of smobs.hh 
.

commit 4a8c6fa94d4c2a482fb91ac53e064aafcb75942f
Author: David Kastrup <d...@gnu.org>
Date:   Sat Apr 18 01:33:50 2020 +0200

    Issue 5916/1: Make GET_LISTENER take a pointer arg and deduce its type
    
    Instead of
    
        Context *p;
        [...]
        Listener l = p->GET_LISTENER (Context, somecallback);
    
    this now uses
    
        Context *p;
        [...]
        Listener l = GET_LISTENER (p, somecallback);
    
    This removes the necessity for providing the somewhat awkward type
    argument.




---

** [issues:#5916] Make GET_LISTENER take a pointer arg and deduce its type**

**Status:** Fixed
**Labels:** Fixed_2_21_1 
**Created:** Fri Apr 17, 2020 11:48 PM UTC by David Kastrup
**Last Updated:** Sun Apr 26, 2020 08:40 AM UTC
**Owner:** David Kastrup


Make GET_LISTENER take a pointer arg and deduce its type

Instead of

    Context *p;
    [...]
    Listener l = p->GET_LISTENER (Context, somecallback);

this now uses

    Context *p;
    [...]
    Listener l = GET_LISTENER (p, somecallback);

This removes the necessity for providing the somewhat awkward type
argument.

http://codereview.appspot.com/549890043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to