Han-Wen Nienhuys escreveu: > Joe Neeman escreveu: >> I have fixed all known regressions in the jneeman branch. The addition >> of max-slope skylines changes slightly the output of >> input/regression/laissez-vibrer.ly <http://vibrer.ly>, but IMHO it looks >> better now (the ties aren't quite so close together). >> >> I haven't yet made max-slope configurable or incorporated Erik's >> suggestion for increasing horizontal distance in skylines. >> >> Are there any objections for me to merge the patch to HEAD? > > No, please go ahead.
out of curiosity, I've pulled your patch and put it into master. Some remarks: - can you use git-rebase for the next time? Now, we get lots of commits duplicated in the log. - I'm missing the input/regression test file showing the new goodies, as well as the NEWS entry - on a random sample (mozart horn concerto), the skyline stuff looks working. However, should we increase the default padding/skyline-padding to improve appearance (see mozart concerto, page 1, bar 68, forte and beam being close)? -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
