On Wed, Jun 18, 2008 at 5:55 PM, Carl D. Sorensen <[EMAIL PROTECTED]> wrote: > Han-Wen, > > I've finally got the csorensen fork ready for cherry picking. It includes a > completely revised file input/regression/fret-diagrams.ly, along with > modifications to scm/define-grobs, scm/define-interfaces, > scm/define-grob-properties, and scm/fret-diagrams. It adds a few new > fret-diagrams properties, and moves all of the fret-diagram-specific > properties out of the general namespace and into fret-diagram-details. > > I've never written a convert-ly rule before, and I don't know how to submit > them if I did (I guess I could just change convert-ly on the csorensen fork, > and then it would be part of the cherry picking). However, for this first > one, I have just created a text file that mentions my intent in the > convert-ly rule and has my guess of what the appropriate code would be. Any > guidance on this rule would be appreciated.
looks good in principle, but don't use i for strings, for prop in props: is more readable imo. I'll try to have a look over the patches over the weekend. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
