On Fri, Jun 26, 2009 at 1:46 PM, Patrick McCarty<[email protected]> wrote: > On Sat, Jun 20, 2009 at 11:55 AM, Patrick McCarty<[email protected]> wrote: >> Hello, >> >> I have uploaded a patch to Rietveld: >> >> http://codereview.appspot.com/83046/show > > Does anyone have comments for this patch?
I will provide some more background information for each output backend, just so that no one has to look through the code to figure it out. ** scm/output-socket.scm When the socket backend is used, the crashes do not occur, because the "catch all" routine is enabled. So, if this "catch all" idea is not the optimal solution, this code should be removed from output-socket.scm. My patch simply revises the routine for consistency. ** scm/output-svg.scm The "catch all" routine is written, but disabled due to the (if #f ...). My patch enables the routine. ** scm/output-ps.scm When I tried to use the "catch all" with the PS backend, `make all' failed. The problem was the "ps-output-expression" procedure in lily.scm, which is obsolete code. The solution is to remove the obsolete module interface code (lily.scm and output-ps.scm), which is included in my patch. The "catch all" routine works as a result. --- Also, I should comment that I have not experienced any problems with this patch. I would grateful if someone could test these changes and/or provide feedback. Thanks, Patrick _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
