Carl, I haven't commenting on them directly, but there are quite a few indentation errors in the .scm files.
http://codereview.appspot.com/88155/diff/95/1147 File Documentation/topdocs/NEWS.tely (right): http://codereview.appspot.com/88155/diff/95/1147#newcode69 Line 69: section 1.2.4 Beams, for more information. Is it possible to use @ruser{} here? http://codereview.appspot.com/88155/diff/95/1149 File Documentation/user/rhythms.itely (right): http://codereview.appspot.com/88155/diff/95/1149#newcode1743 Line 1743: Beam settings can be reverted to get back to default behavior. This This looks like it should be an input/new snippet. http://codereview.appspot.com/88155/diff/95/1155 File input/lsr/conducting-signs,-measure-grouping-signs.ly (right): http://codereview.appspot.com/88155/diff/95/1155#newcode77 Line 77: } missing %begin verbatim http://codereview.appspot.com/88155/diff/95/1155#newcode88 Line 88: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/95/1170 File lily/measure-grouping-engraver.cc (right): http://codereview.appspot.com/88155/diff/95/1170#newcode71 Line 71: scm_list_2 (time_signature_fraction, same line as ly_assoc_get ( http://codereview.appspot.com/88155/diff/95/1170#newcode72 Line 72: ly_symbol2scm ("end")), indentation http://codereview.appspot.com/88155/diff/95/1170#newcode75 Line 75: grouping_rules, SCM_EOL); indentation http://codereview.appspot.com/88155/diff/95/1177 File scm/c++.scm (right): http://codereview.appspot.com/88155/diff/95/1177#newcode30 Line 30: (define-public (pair-or-symbol? x) also unused http://codereview.appspot.com/88155 _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
