On 8/12/09 10:36 AM, "Mark Polesky" <markpole...@yahoo.com> wrote:

> Carl Sorensen wrote:
> 
>>> When doing a convert-ly rule, do I update snippets/regression tests?
>> 
>> The correct question is:  When changing syntax, what do I do besides writing
>> a convert-ly rule?
> 
> Okay, that covers the snippet, but what about the regression test?
> Do I just update it manually? In my case, the one involved is
> input/regression/whiteout.ly. Do I do:
> 
> \version "2.12.0" -> \version "2.13.4"
> "\pad-markup" -> "\pad-around"
> 
> Or do I just leave it alone, the idea being that convert-ly is
> run on the regression tests anyway?

I think you *need* to update the regression test to make sure that your
patch has worked.  You should never push a patch without verifying that the
regression tests work.

> 
> Sorry if I'm being dense.

No, you're being careful.  I appreciate it.

Carl



_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to