On Sun, May 16, 2010 at 2:35 PM, Karl Hammar <k...@aspodata.se> wrote: > Neil Puttock: >> > Also, it would be much easier to look throuht the patch if it did not >> > contain so many whitespace changes. In the first 100lines, I see: >> >> Why would you want to look at the bare diff? > > Isn't the diff a complete statement of what you want to change? > Also you *did* cite the diff.
Yes. One of these days, we'll pin down our C++ whitespace desires, update/create a tool to do this automatically, finish merging any old patches, then run it on all our sources to get rid of this stupid problem once and for all. Sadly, we don't have the developer resources to do this now. If anybody thinks that the first couple of items on the above list are already done, I don't want to hear about it. Running fixcc.py on the /lily/ dir produces a diff that's over 100 kb; refering to this as having our desires "pinned down" is silly. > $ fgrep '<img src="input/regression/out-test/' out/test-results/index.html | > grep -v test-output-distance.compare.jpeg > <img src="input/regression/out-test//rest-collision-beam-note.compare.jpeg" > style="border-style: none; max-width: 500px;"> That can *sigh* be ignored. This particular regtest changes every time we compile stuff. In particular, I recognize the attached output as being one of the two "regular" outputs from that file. Yes, an unreliable regtest is pretty bad, but "fortunately" there's "only" one of them. Interested people can read about it here: http://code.google.com/p/lilypond/issues/detail?id=1031 > What can I say? FWIW, everything looks in order. Of course, not having much to do on the programming side of things "it's worth" isn't much in this case. Cheers, - Graham _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
