On 2010/08/01 14:27:05, Neil Puttock wrote:
http://codereview.appspot.com/1908041/diff/10002/18002
File python/convertrules.py (right):
http://codereview.appspot.com/1908041/diff/10002/18002#newcode3014
python/convertrules.py:3014: 'accDot': 'dot',
indent
http://codereview.appspot.com/1908041/diff/10002/18002#newcode3018
python/convertrules.py:3018: 'accOldEE': 'oldEE'}
missing 'accDiscant'
http://codereview.appspot.com/1908041/diff/10002/18002#newcode3019
python/convertrules.py:3019: return '"\1%s"' % d[m.group (2)]
This doesn't work for the `accordion.' part: it returns the matched
object
rather than the string.
It seems you need to expand the backreference and add an extra
backslash:
return m.expand ('"\\1%s"' % d[m.group (2)])
Fixed that, checked that it works, ocnverted the related snippet.
I am still not convinced that the versioning is sane, but would
consider this a candidate for pushing otherwise.
http://codereview.appspot.com/1908041/show
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
