Hi Joe, LGTM.
I'd be quite happy with this method, even though it loses a bit of flexibility in comparison with your original patch. Cheers, Neil http://codereview.appspot.com/1888042/diff/1/5 File lily/keep-alive-together-engraver.cc (right): http://codereview.appspot.com/1888042/diff/1/5#newcode69 lily/keep-alive-together-engraver.cc:69: "All the Hara_kiri_group_spanners that lie below " Could this docstring be a bit more user-friendly? http://codereview.appspot.com/1888042/diff/1/7 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/1888042/diff/1/7#newcode956 scm/define-grob-properties.scm:956: (keep-alive-with ,ly:grob-array? "An array of other VerticalAxisGroups. @code{VerticalAxisGroup}s http://codereview.appspot.com/1888042/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
