Graham Percival wrote Friday, August 27, 2010 9:54 PM

Anyway, 2.1.7.

[snip]

"Setting annotate-spacing = ##t in the layout block..."

Could I convince you to remove that part, and just link to Displaying
spacing ?

Done

I'd rather that you @ref{Fitting music onto fewer pages} rather than @ref{Changing spacing}. The first @ref{} is pretty self-explanatory,
and I'd rather emphasize our (mostly?) well-named sections.

Done

More
generally, it might be worth combining the last two points in that
list.

Done

- introduce examples with punctuation; we no longer allow sentences which
  \markup{ run directly into an example }

Done

- do you absolutely need to use an @example rather than @lilypond for
the page-separator-markup ?
That said, we really try to avoid repeating information that's
elsewhere.  Unfortunately, the current doc page about
page-separator-markup is rather un-optimal.
If this were GDP, I'd run off and fix this by making a separate
section right away, but for now I'll simply state it as a problem.

For now I've added an @lilypond, the smallest I
could devise that was realistic.  Is this OK?
(Note it overwrites the \paper block)

System separators are only useful in multi-staff
documents, essentially full orchestral or choral
scores, so maybe it shouldn't have a section in
the main text.  As we don't have a specialist
section devoted to orchestral writing (yet) this
Choral section seems the best place.

- can't you do \layout { \context { \dynamicsUp }} ? After mentioning \dynamicsUp, it feels really weird to see the arcane \override command
in there.

No, it seems predefs are not permitted in \context
blocks:

D:/Users/Trevor/Leisure/Music/LilyPond/Tests/test4.ly:9:6:
error: syntax error, unexpected MUSIC_IDENTIFIER
     \dynamicUp

Also, do you absolutely need an @example rather than @lilypond ?
Also*2, as a stupid reader I'm really confused by "use the following in a \layout block within the \score block". I'd really rather see a
@lilypond rather than a textual description followed by a
non-graphical @example.

OK, changed to an @lilypond

The predef looks weird without \dynamicsDown and \dynamicsBoth.  I
know why you only put \...Up in there, but I think it would look
better with all three instead.

Done

- not related to Vocal, but I winced a bit when seeing @ref{Lines}. It might be better to rename this to "Expressive marks as lines" or "Line-style expressions" or something... "Lines" by itself looks fine
if you're looking at the ToC, but by itself it's a bit confusing.
Again, in GDP style I'd make a special note of this and come back to
it in a day or two.

Yes.  I'll change it in a separate commit shortly.

I've just pushed these changes.

[snip 2.1.9 }

To follow ...

Trevor



_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to