New patch-set uploads (well two actually, but please review the latest).
Code in display-lily.scm to support Guile V2 now tested on Guile 1.8.7 system. Cheers, Ian http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode227 scm/lily.scm:227: (use-modules (ice-9 curried-definitions)))) On 2010/10/21 00:12:21, Patrick McCarty wrote:
In this section, the parenthesis nesting needs some adjustment.
It should be
((guile-v2) (if (ly:get-option 'verbose) (ly:message (_ "Using (ice-9 curried-definitions) module\n"))) (use-modules (ice-9 curried-definitions)))
Done. http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode231 scm/lily.scm:231: (_ "Guile 1.8\n"))))) On 2010/10/20 21:58:07, Patrick McCarty wrote:
Okay, I can live with this. :)
Ta http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode271 scm/lily.scm:271: (debug-enable 'debug) On 2010/10/20 21:58:07, Patrick McCarty wrote:
On 2010/10/20 21:42:06, ianhulin44 wrote: > This causes a deprecation warning from Guile V1.9.13 with > $ declare -x GUILE_WARN_DEPRECATED="detailed" > > [/home/ian/lilypond/out/share/lilypond/current/scm/lily.scm] > `(debug-enable 'debug)' is obsolete and has no effect. > Remove it from your code.
Go ahead. There is another instance of `(debug-enable 'debug)'
earlier in this
file, so you can remove that too.
Done. http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode332 scm/lily.scm:332: (set-module-name! iface (module-name mod)) On 2010/10/20 21:58:07, Patrick McCarty wrote:
Please change this so that it uses a tab again.
Done. http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode338 scm/lily.scm:338: (fresh-interface!)))) On 2010/10/20 21:58:07, Patrick McCarty wrote:
This line too.
Done. http://codereview.appspot.com/2219044/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel