Great work! I can't really speak to the font stuff. You can make your C++ code a lot shorter by using arrays. And I see that you've wiped a lot of the tabbing in the original code. You may want to start by copying a fresh version of the file into your git repository and then copying and pasting the new code into that to save you the headache of dealing w/ all of those tabs.
Other than that, arrays are your friend. Everything else looks good! http://codereview.appspot.com/4134041/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode92 lily/stem.cc:92: Staff_symbol_referencer::get_position (e[UP])); Try to keep the same indentation from the previous file (here, there were 2 tabs). http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode190 lily/stem.cc:190: while (flip (&d) != DOWN); Ditto. http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode231 lily/stem.cc:231: } Ditto. http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode246 lily/stem.cc:246: { Ditto. I'll stop "dittoing," but check out the side by side diff to rectify this :) http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode350 lily/stem.cc:350: Direction dir = get_grob_direction (me); Try: Real potential_lengths[] = {7,7,7,7,8.5,10,11.5}; length = potential_lengths[durlog-1]; http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode373 lily/stem.cc:373: } Same approach as above - you can use an array here. http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode388 lily/stem.cc:388: length -= shorten; You can also use an array here. Real potential_shortenings[] = {0.833,0.666,0.555,0.333,0.166}; shorten *= potential_shortenings[(int)(head_positions (me)[dir])]; http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode715 lily/stem.cc:715: } Ditto - use arrays. http://codereview.appspot.com/4134041/diff/1/lily/stem.cc#newcode728 lily/stem.cc:728: } Same - arrays can be used here (see above for how to handle else if). http://codereview.appspot.com/4134041/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
